Bump globby from 6.1.0 to 14.0.2 #823
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/globby-14.0.2
branch
from
00f8a74 to
e2d2db2
Compare
Bumps [globby](https://github.com/sindresorhus/globby) from 6.1.0 to 14.0.2. - [Release notes](https://github.com/sindresorhus/globby/releases) - [Commits](sindresorhus/globby@v6.1.0...v14.0.2) --- updated-dependencies: - dependency-name: globby dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
nucleogenesis
force-pushed
the
dependabot/npm_and_yarn/globby-14.0.2
branch
from
9688ef2 to
c3e7af0
Compare
|
I've pushed a commit here that removes 'globby' altogether and instead uses the Node 'glob' module to the same effect. @AlexVelezLl or @MisRob could you please give this a closer look to be sure that I've not missed anything? |
AlexVelezLl
reviewed
Jan 7, 2025
There was a problem hiding this comment.
I am curious if we are using a node built-in glob package, or if glob is resolving because other libraries requires this:
When I clicked on the package in vscode to see what file was it referencing, it led me to this glob package installed in the node_modules.
| const output = {}; | ||
|
|
||
| for (const filename of simpleFiles.filter(notTest)) { | ||
| for (const filename of Array.from(simpleFiles).filter(notTest)) { |
There was a problem hiding this comment.
I think here we wouldnt need to use Array.from again, since in the definition of simpleFiles we already use Array.from right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps globby from 6.1.0 to 14.0.2.
Release notes
Sourced from globby's releases.
... (truncated)
Commits
c00056814.0.2f600250Fix typesb0d733014.0.1a85078eMeta tweaksaf5d139FixexpandDirectories.extensionoption (#263)3a28601Fix read permission error on ignore files search (#259)bd7637414.0.03bd00a6AddconvertPathToPattern()method2c06ae5Require Node.js 1876c70ab13.2.2Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)